Clean up local yawollet image build #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timebertt
requested review from
dergeberl,
einfachnuralex,
Kumm-Kai and
maboehm
as code owners
maboehm
approved these changes
Sep 10, 2024
timebertt
force-pushed
the
cleanup-local-build
branch
from
83d5f17
to
ce8c897
Compare
When developing and performing many builds, one might be required to set a GitHub API token in packer for resolving rate limits.
timebertt
force-pushed
the
cleanup-local-build
branch
from
ce8c897
to
3ab40a2
Compare
maboehm
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves and fixes several things for locally building yawollet images.
Most notably, this PR fixes builds from other platforms than
linux/amd64to result in the right target platform.