Allow configuring NTP pools and servers for LBMs #411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timebertt
requested review from
dergeberl,
einfachnuralex,
Kumm-Kai and
maboehm
as code owners
timebertt
force-pushed
the
ntp-servers
branch
from
4992eaf
to
87c858f
Compare
maboehm
reviewed
Sep 10, 2024
There was a problem hiding this comment.
I have not used it before, but could you please investigate using the ntp cloud-init config instead? https://cloudinit.readthedocs.io/en/latest/reference/modules.html#ntp Seems like that could be a simpler way to configure NTP if all we want to adjust is pools and servers.
It seems desirable to start chrony as soon as possible even if it doesn't have its final config yet. If the clock is off by too much, chrony should perform a step instead of slewing the clock. It's better to do this quickly after boot before time-sensitive processes might notice.
timebertt
force-pushed
the
ntp-servers
branch
from
87c858f
to
dd08186
Compare
|
@maboehm please take another look, I have addresses your feedback :) |
maboehm
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds options (flags and corresponding helm values) to the yawol-controller for configuring NTP pools and servers for LoadBalancerMachines.
The LBM controller passes the configured NTP pools and servers to the chrony config via user-data.
If no NTP pools and servers are configured, it falls back to the current chrony default config, i.e., uses
pool.ntp.org.The
chronydservice is restarted after writing the config file.Note: this PR also bumps the chart version to
0.25.0.Once this PR and #408 have been merged, we should also create a new release.