Skip to content
This repository was archived by the owner on Feb 13, 2025. It is now read-only.

calling PyTasklet_New( NULL, ...) crashes #129

Closed
ghost opened this issue Apr 15, 2017 · 1 comment
Closed

calling PyTasklet_New( NULL, ...) crashes #129

ghost opened this issue Apr 15, 2017 · 1 comment

Comments

@ghost
Copy link

ghost commented Apr 15, 2017

Originally reported by: Anselm Kruis (Bitbucket: akruis, GitHub: akruis)


Affected version: all

Problem

Jun Liu reported on the Stackless mailing list, that calling PyTasklet_New( NULL, ...) crashes (http://www.stackless.com/pipermail/stackless/2017-April/006470.html). The documentation explicitly allows NULL as first argument.

Looking at the history of PyTasklet_New I found the changes 20dad21ded9c (2.7-slp) and dae0e80f141d (3.2-slp), which remove - probably by accident - a if (type == NULL) type = &PyTasklet_Type;. The documentation needs some love too: what does "via capture()" mean?

Proposed Solution

I'll re-add the check for NULL and update the documentation.


@ghost
Copy link
Author

ghost commented Apr 15, 2017

Original comment by Anselm Kruis (Bitbucket: akruis, GitHub: akruis):


Fixed in changeset:

  • 2.7-slp: a4dfdadc7cf5
  • 3.3-slp: b9f30046865a
  • 3.4-slp: a36a062d5b8c
  • 3.5-slp: 3653d6a652ea

Not yet merged to default-slp

@ghost ghost added this to the 2.7.14-slp milestone Sep 24, 2017
@ghost ghost closed this as completed Sep 24, 2017
akruis pushed a commit that referenced this issue Oct 29, 2017
Re-add the test for NULL. It got lost in change 20dad21ded9c (2.7-slp) and dae0e80f141d (3.2-slp). Update the documentation.

https://bitbucket.org/stackless-dev/stackless/issues/129
(grafted from a4dfdadc7cf547e7f589e8191b8bab2c67e34f00)
akruis pushed a commit that referenced this issue Mar 4, 2018
The presence of the ``--enable-optimizations`` flag is indicated by the
value of ``$enableval``, but the configure script was checking ``$withval``,
resulting in the ``--enable-optimizations`` flag being effectively ignored.
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

0 participants