Skip to content
This repository was archived by the owner on Feb 13, 2025. It is now read-only.

Replace copied code in pricklepit.c dictview_new #144

Closed
akruis opened this issue Dec 20, 2017 · 2 comments
Closed

Replace copied code in pricklepit.c dictview_new #144

akruis opened this issue Dec 20, 2017 · 2 comments
Assignees
@akruis
Labels
3.5-slp 3.6-slp bug main-slp stackless python
Milestone
v3.6.x-slp

Comments

@akruis
Copy link

akruis commented Dec 20, 2017 •
edited
Loading

pricklepit.c contains a copy of _PyDictViewObject and _PyDictView_New. Unfortunately _PyDictView_New was changed (2eea952) and now the copy is out of sync. An assertion failure is the outcome. Theses copies were required in previous versions of Stackless, when the original definitions had a "static" scope.

I'll replace the copied code and use the original definitions.
@akruis akruis added this to the v3.6.x-slp milestone Dec 20, 2017
@akruis akruis self-assigned this Dec 20, 2017
@akruis akruis changed the title Replace duplicated code in pricklepit.c dictview_new Replace copied code in pricklepit.c dictview_new Dec 20, 2017
akruis pushed a commit that referenced this issue Dec 21, 2017
Stackless issue #144: Replace copied code in pricklepit.c dictview_new
096ad87 
Replace copied code by a limited API function. This fixes the assertion
error caused by commit 2eea952.
akruis pushed a commit that referenced this issue Dec 21, 2017
Stackless issue #145: fix test_doctest
7327e4b 
Stackless contributes two tests to builtins: TaskletExit and
TaskletExit.__init__. Therefore we have to adjust the limit.

Add missing changelog entries (#143, #144).
akruis pushed a commit that referenced this issue Dec 21, 2017
Stackless issue #144: Replace copied code in pricklepit.c dictview_new
1f23d4c 
Replace copied code by a limited API function. This fixes the assertion
error caused by commit 2eea952.
(cherry picked from commit 096ad87)
akruis pushed a commit that referenced this issue Dec 21, 2017
Stackless issue #145: fix test_doctest
8d02cf8 
Stackless contributes two tests to builtins: TaskletExit and
TaskletExit.__init__. Therefore we have to adjust the limit.

Add missing changelog entries (#143, #144).

(cherry picked from commit 7327e4b)
@akruis
Copy link
Author

akruis commented Dec 21, 2017

Not relevant for 2.7-slp, because Stackless 2.7 can't pickle dictviews.

akruis pushed a commit that referenced this issue Dec 21, 2017
Stackless issue #144: Replace copied code in pricklepit.c dictview_new
06f9551 
Replace copied code by a limited API function. This fixes the assertion
error caused by commit 2eea952.
(cherry picked from commit 096ad87)
akruis pushed a commit that referenced this issue Dec 21, 2017
Stackless issue #145: fix test_doctest
0c66149 
Stackless contributes two tests to builtins: TaskletExit and
TaskletExit.__init__. Therefore we have to adjust the limit.

Add missing changelog entries (#143, #144).

(cherry picked from commit 7327e4b)
@akruis
Copy link
Author

akruis commented Dec 22, 2017

Fixed in master-slp, 3.6-slp and 3.5-slp.

@akruis akruis closed this as completed Dec 22, 2017
@akruis akruis mentioned this issue Dec 22, 2017
Closed
7 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@akruis akruis

Labels
3.5-slp 3.6-slp bug main-slp stackless python
Projects
None yet
Milestone
v3.6.x-slp
Development

No branches or pull requests
1 participant
@akruis