Skip to content
This repository was archived by the owner on Feb 13, 2025. It is now read-only.

Unify and fix tasklet.kill(), tasklet.throw() and tasklet.raise_exception() #93

Closed
ghost opened this issue Sep 25, 2016 · 3 comments
Closed

Comments

@ghost
Copy link

ghost commented Sep 25, 2016

Originally reported by: Anselm Kruis (Bitbucket: akruis, GitHub: akruis)


The implementations of all three methods differ in their error handling. And they contain bugs in corner cases, especially if a tasklet has no thread state (various assertion violations).
I created a unified implementation of all three methods.


@ghost
Copy link
Author

ghost commented Sep 25, 2016

Original comment by Anselm Kruis (Bitbucket: akruis, GitHub: akruis):


Test cases (still skipped) for 2.7-slp are in 1399a7b0c676.

@ghost
Copy link
Author

ghost commented Oct 20, 2016

Original comment by Anselm Kruis (Bitbucket: akruis, GitHub: akruis):


The fix for 2.7-slp is in pull request #18 (merged).

@ghost
Copy link
Author

ghost commented Nov 12, 2016

Original comment by Anselm Kruis (Bitbucket: akruis, GitHub: akruis):


Fixed:

  • 3.3-slp: e3d5e6b2300f
  • 3.4-slp: e81d51157952, ff1e833e4ac6
  • default-slp: 120f33c1443c, 3b8d3cd58009

@ghost ghost added this to the 3.3.7-slp milestone Sep 24, 2017
@ghost ghost closed this as completed Sep 24, 2017
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

0 participants