Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to skip pinning latest tagged images #150

Closed
2 tasks
rdimitrov opened this issue Jun 12, 2024 · 0 comments · Fixed by #159
Closed
2 tasks

Add an option to skip pinning latest tagged images #150

rdimitrov opened this issue Jun 12, 2024 · 0 comments · Fixed by #159
Assignees

Comments

@rdimitrov
Copy link
Member

rdimitrov commented Jun 12, 2024

Details:
Perhaps same goes for actions pinned by a branch, i.e. @main

Follow-up work:
This option should be propagated to:

  • frizbee-action
  • minder

The defaults there should be not pin latest images.

Reasoning:
Using latest is not suggested but at least keeps the dependency updated whereas if we pin it and they don't have dependabot enabled it might become an issue later.

jhrozek added a commit to jhrozek/frizbee that referenced this issue Jun 17, 2024
Adds two configuration options that let the user skip images that are
either matching the configured image name or tag.

Related: stacklok#150
jhrozek added a commit to jhrozek/frizbee that referenced this issue Jun 17, 2024
- Fixes the default container regex to handle `FROM` directives that use
  a platform. Retains them when returning the modified reference
- uses buildkit's dockerfile parser to get access to a real parser and use it
  to properly extract the image name and arguments such as `--platform` without
  brittle homecooked parsing
- extends the image skipping to skip images or tags based on
  configuration
- adds tests

Fixes: stacklok#150
Fixes: stacklok#157
jhrozek added a commit to jhrozek/frizbee that referenced this issue Jun 17, 2024
Adds two configuration options that let the user skip images that are
either matching the configured image name or tag.

Related: stacklok#150
@jhrozek jhrozek linked a pull request Jun 17, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants