Remove backticks in vulncheck details template.

It currently looks weird in the UI, we'll get rid of them for now.
stacklok · Sep 20, 2024 · 7727ef2 · 7727ef2
1 parent 4ba7558
commit 7727ef2
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 13 deletions.
diff --git a/internal/engine/errors/errors_test.go b/internal/engine/errors/errors_test.go
@@ -19,8 +19,6 @@ import (
  "testing"
 
  "github.com/stretchr/testify/require"
-
- "github.com/stacklok/minder/internal/engine/eval/templates"
 )
 
 func TestLegacyEvaluationDetailRendering(t *testing.T) {
@@ -113,15 +111,6 @@ func TestEvaluationDetailRendering(t *testing.T) {
  error: "evaluation failure: this is the message",
  details: "evaluation failure: this is the message",
  },
- // vulncheck template
- {
- name: "vulncheck template",
- msg: "this is the message",
- tmpl: templates.VulncheckTemplate,
- args: map[string]any{"packages": []string{"boto3", "urllib3", "python-oauth2"}},
- error: "evaluation failure: this is the message",
- details: "Vulnerable packages found:\n* `boto3`\n* `urllib3`\n* `python-oauth2`\n",
- },
  }
 
  for _, tt := range tests {

diff --git a/internal/engine/eval/templates/vulncheckTemplate.tmpl b/internal/engine/eval/templates/vulncheckTemplate.tmpl
@@ -1,4 +1,4 @@
 Vulnerable packages found:
 {{- range .packages }}
-* `{{- . -}}`
+* {{ . }}
 {{- end }}
diff --git a/internal/engine/eval/vulncheck/vulncheck_test.go b/internal/engine/eval/vulncheck/vulncheck_test.go
@@ -42,7 +42,7 @@ func TestEvaluationDetailRendering(t *testing.T) {
  tmpl: templates.VulncheckTemplate,
  args: map[string]any{"packages": []string{"boto3", "urllib3", "python-oauth2"}},
  error: "evaluation failure: this is the message",
- details: "Vulnerable packages found:\n* `boto3`\n* `urllib3`\n* `python-oauth2`\n",
+ details: "Vulnerable packages found:\n* boto3\n* urllib3\n* python-oauth2\n",
  },
  }