Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group otel-related updates into single PRs. #4490

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

blkt
Copy link
Contributor

@blkt blkt commented Sep 16, 2024

Summary

This should make merging dependabot PRs about tracing easier to handle.

Change Type

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@blkt blkt self-assigned this Sep 16, 2024
@eleftherias
Copy link
Member

Should we also group them with the otel upgrades? I see the splunk package we use are splunk-otel-go

@coveralls
Copy link

Coverage Status

coverage: 53.146% (+0.004%) from 53.142%
when pulling f8f6f52 on chore/dependabot-group-splunk-otel-go
into 967f7d1 on main.

@blkt
Copy link
Contributor Author

blkt commented Sep 16, 2024

They were released some days apart from one another, I guess the impact would be that we would delay upgrading otel-only dependencies in that case. I'm ok if we want to merge them together.

This PR is mainly to avoid having two PRs as we do in this very moment

  • one upgrading only github.com/signalfx/splunk-otel-go/instrumentation/database/sql/splunksql
  • the other upgrading both that and github.com/signalfx/splunk-otel-go/instrumentation/github.com/lib/pq/splunkpq

@blkt blkt force-pushed the chore/dependabot-group-splunk-otel-go branch 2 times, most recently from dc7f82b to b49abb3 Compare September 19, 2024 08:51
@blkt
Copy link
Contributor Author

blkt commented Sep 19, 2024

@eleftherias I couldn't root-cause the panics we had when both libraries were updated, but I integrated your suggestion.

@blkt blkt force-pushed the chore/dependabot-group-splunk-otel-go branch from b49abb3 to 289d8ca Compare September 20, 2024 07:43
@blkt blkt changed the title Group splunk dependency updates into single PRs. Group otel-related updates into single PRs. Sep 20, 2024
@blkt blkt force-pushed the chore/dependabot-group-splunk-otel-go branch from 289d8ca to 4ee6bb9 Compare September 20, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants