fix(check-server): invalidate workload list with the group and refactor #1190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes workload list invalidation during server status polling by including the current group in the query key, and refactors mutation handlers to use properly typed parameters. The changes align with the reported issue where invalidation after checking server status wasn't scoped to the current group.
Key changes:
- Fixed query invalidation to include the group parameter when polling server status
- Refactored mutation context parameters for better type clarity
- Removed unnecessary type assertions throughout the codebase
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| renderer/src/common/hooks/use-check-server-status.tsx | Added group parameter to query key when invalidating workload list after server status check |
| renderer/src/features/mcp-servers/hooks/use-mutation-update-workload.ts | Added explicit typing to getQueryData call and renamed context parameters for clarity |
| renderer/src/features/mcp-servers/hooks/use-mutation-restart-server.ts | Removed unnecessary type assertion from status response mapping |
| renderer/src/features/mcp-servers/components/actions-mcp-server.tsx | Reordered status check for 'stopping' to appear before 'updating' |
kantord
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR: