fix: bring back the logic of mcp utils #1243
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the McpToolDefinition type and improves the type safety and implementation of the isMcpToolDefinition function. The changes also streamline the tool validation and filtering logic.
- Changed
McpToolDefinitionfrom a type alias to an interface with explicit properties - Updated the
isMcpToolDefinitiontype guard signature to accept aToolparameter instead ofunknown - Refactored the tool filtering logic to use a functional approach with
filterandreduce
peppescg
approved these changes
Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the bump of the libs I touched this file but was not correct, I just revert the type and logic as before.
This fix the retrival of tools for tool override.