-
Notifications
You must be signed in to change notification settings - Fork 109
Support colima #1332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support colima #1332
Conversation
@goshlanguage This makes sense to me. Feel free to update the branch and take it out of draft status. |
I added a PR that does almost exactly the same thing. I wanted to 👍 the support for this PR. I updated all of the docs to include Colima in mine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @goshlanguage! I've added a suggestion inline about how this could be simplified.
@eleftherias seems that your suggestion then will only work for Colima on mac, and not colima on linux. Are you sure that's what we want? Means I still can't use this on my linux environments. edit: I haven't confirmed, so I will test this. I do like less code |
yeah unfortunately it looks like that's not a compatible approach: ➜ toolhive git:(support-colima) ./bin/thv client setup
A new version of ToolHive is available: v0.2.13
Currently running: vf0c65e0
Error: failed to create client manager: no supported container runtime available: container runtime not found |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for trying it out on Linux! We do want it to work on both.
With the current proposal does it work on Linux, or is there still more to be done?
It worked with the original implementation. What do we want to do here? Restore that? |
Yes, let's get back to the one that worked on Linux as well. |
0f9485e
to
f80cb89
Compare
f80cb89
to
51c3266
Compare
51c3266
to
4327cf8
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1332 +/- ##
==========================================
- Coverage 38.51% 38.45% -0.07%
==========================================
Files 174 174
Lines 20233 20265 +32
==========================================
Hits 7792 7792
- Misses 11870 11902 +32
Partials 571 571 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for you effort on this @goshlanguage!
I needed to add
colima
in order to usethv
in my current setup. Opening as draft as I'm traveling as I write this PR and haven't given due diligence of going through the Dev Guide. Hoping to share for guidance.Before:
After: