Skip to content

Conversation

ChrisJBurns
Copy link
Collaborator

Wanted to get some early thoughts on this.

@ChrisJBurns to refine technical details if needed

Signed-off-by: ChrisJBurns <29541485+ChrisJBurns@users.noreply.github.com>
@ChrisJBurns ChrisJBurns marked this pull request as draft August 19, 2025 19:09
Signed-off-by: ChrisJBurns <29541485+ChrisJBurns@users.noreply.github.com>
Signed-off-by: ChrisJBurns <29541485+ChrisJBurns@users.noreply.github.com>
Signed-off-by: ChrisJBurns <29541485+ChrisJBurns@users.noreply.github.com>
@RoddieKieley
Copy link
Contributor

Initial thoughts. This makes a lot of sense to me @ChrisJBurns. The operator should indeed be taking responsibility for both the deployment and statefulset creation, and then also their association with various kubernetes services and other resources such that their reconciliation and reclamation can happen cleanly.

I also like the idea of having the proxy still being able to request an mcp server replica + or - depending on the load it is experiencing, and while the operator has the big picture the proxy will have the data to determine the need most directly.


As described above, the current deployment architecture has it's pains. The aim with the new proposal is to make these pains less painful (hopefully entirely) by moving some of the responsibilities over to other components of ToolHive inside of a Kubernetes context.

As described above, the current deployment architecture has several pain points. The goal of this proposal is to reduce (ideally eliminate) those issues by shifting certain responsibilities to more appropriate components within ToolHive’s Kubernetes deployment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two "As described above" sections seem equivalent

@dmartinol
Copy link

Thanks for updating the architecture and making it more coherent with standard k8s deployments @ChrisJBurns.
IMO, it could help to highlight the role of the auxiliary services (I mean k8s Service) and how the network topologies work from a consumer perspective, and whether it changes depending on the container transport and the exposed service transport.

@jhrozek
Copy link
Contributor

jhrozek commented Aug 28, 2025

great work thanks @ChrisJBurns

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants