Add PreRunConfig abstraction for MCP server source classification #1570
+1,572
−271
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR introduces a new PreRunConfig system that cleanly separates the concern of 'what type of thing are we running' from 'how do we run it'. This provides type-safe input classification and improves code maintainability.
Key Changes
New Components
PreRunConfig types: Distinct types for different source categories:
ParsePreRunConfig function: Comprehensive input classification with clear error messages
PreRunTransformer: Type-specific transformation logic from PreRunConfig to RunConfig
RunFlagsInterface: Clean interface abstraction to avoid circular dependencies
Refactoring
Testing
Benefits
Backward Compatibility
Testing
The new PreRunConfig system provides a solid foundation for handling different types of MCP server sources in a type-safe, maintainable way while maintaining full backward compatibility.