Add tool name override to tool middleware. #1612
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JAORMX
previously approved these changes
Aug 29, 2025
|
As suggested by @JAORMX via chat, I'm adding test coverage for the whole middleware. |
This change makes use of the provided filter and override configuration in tool middlewares. Both middlewares now process `tools/call` and `tools/list` commands by checking both overrides and filtering, specifically: * `tools/list` responses, which the proxy received from the real MCP server, must be modified to contain tools whose names might be overridden (as well as filtered) * `tools/call` requests, which the proxy received from the Client, must be modified to refer to the original tool name As a refresher for the reviewer, keep in mind that filtering is expressed in terms of tool names used by the client, so the user-visible (or client-visible) name must be determined before the lookup on the filter. This makes it so that * `tools/list` must first look the override up and only then check the filter, while * `tools/call` must first check the filter and only then look the override up Fixes #1513
blkt
force-pushed
the
feat/add-tool-override-support-to-middleware
branch
from
1168cb3 to
735b708
Compare
|
OK, I fixed a few bugs and added more tests for tool management middleware, this is ready for final review and can be merged any time. |
eleftherias
approved these changes
Aug 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes use of the provided filter and override configuration in tool middlewares. Both middlewares now process
tools/callandtools/listcommands by checking both overrides and filtering, specifically:tools/listresponses, which the proxy received from the real MCP server, must be modified to contain tools whose names might be overridden (as well as filtered)tools/callrequests, which the proxy received from the Client, must be modified to refer to the original tool nameAs a refresher for the reviewer, keep in mind that filtering is expressed in terms of tool names used by the client, so the user-visible (or client-visible) name must be determined before the lookup on the filter. This makes it so that
tools/listmust first look the override up and only then check the filter, whiletools/callmust first check the filter and only then look the override upFixes #1513