Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement UI for a server list in DeltaClientGtk #184

Merged
merged 2 commits into from
Oct 25, 2023

Conversation

ninjadev64
Copy link
Contributor

Description

This PR implements UI for a server list in DeltaClientGtk. It may be followed with another PR that implements actually storing servers, but as of this PR they are not persisted.

Fixes #183

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation comments
  • My changes generate no new warnings

Copy link
Owner

@stackotter stackotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good so far 👌 The UI feels surprisingly smooth given that SwiftCrossUI is still pretty WIP. Apart from the review comments I've left, the only other thing is that it'd be nice to be able remove servers from the list, but it's all good if you don't want to do that in this PR.

Sources/ClientGtk/ServerListView.swift Outdated Show resolved Hide resolved
Sources/ClientGtk/ServerListView.swift Outdated Show resolved Hide resolved
Sources/ClientGtk/ServerListView.swift Outdated Show resolved Hide resolved
Sources/ClientGtk/ServerListView.swift Outdated Show resolved Hide resolved
Sources/ClientGtk/ServerListView.swift Outdated Show resolved Hide resolved
Sources/ClientGtk/ServerListView.swift Outdated Show resolved Hide resolved
Sources/ClientGtk/ServerListView.swift Outdated Show resolved Hide resolved
Sources/ClientGtk/ServerListView.swift Outdated Show resolved Hide resolved
Sources/ClientGtk/ServerListView.swift Outdated Show resolved Hide resolved
@ninjadev64
Copy link
Contributor Author

All done 👍

@ninjadev64
Copy link
Contributor Author

ninjadev64 commented Oct 25, 2023

I'll add removing servers later today so don't merge yet

@ninjadev64
Copy link
Contributor Author

Actually nvm, I'll add removing and editing as part of my next PR - feel free to merge.

Copy link
Owner

@stackotter stackotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for implementing this! 🎉 It'll be cool to see the Linux UI progressing a bit more. I might start using it as a testing ground for SwiftCrossUI

@stackotter stackotter merged commit a5c834d into stackotter:main Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add server list to DeltaClientGtk (the UI for non-Apple platforms)
2 participants