-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement UI for a server list in DeltaClientGtk #184
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good so far 👌 The UI feels surprisingly smooth given that SwiftCrossUI is still pretty WIP. Apart from the review comments I've left, the only other thing is that it'd be nice to be able remove servers from the list, but it's all good if you don't want to do that in this PR.
All done 👍 |
|
Actually nvm, I'll add removing and editing as part of my next PR - feel free to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for implementing this! 🎉 It'll be cool to see the Linux UI progressing a bit more. I might start using it as a testing ground for SwiftCrossUI
Description
This PR implements UI for a server list in DeltaClientGtk. It may be followed with another PR that implements actually storing servers, but as of this PR they are not persisted.
Fixes #183
Type of change
Checklist: