Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile PATH fix #20

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Makefile PATH fix #20

wants to merge 2 commits into from

Conversation

mtesseract
Copy link

@mtesseract mtesseract commented Oct 19, 2022

Apparently the Makefile currently does not handle whitespaces correctly in PATH.

Switched to branch 'main'
Your branch is up to date with 'origin/main'.
➜  helmtest git:(main) ✗ PATH="/foo bar/bin:/usr/local/bin:/bin:/usr/bin" make go-generated-srcs     
env: bar/bin:/usr/local/bin:/bin:/usr/bin: No such file or directory
make: *** [deps] Error 127
➜  helmtest git:(main) ✗ PATH="/foo/bar/bin:/usr/local/bin:/bin:/usr/bin" make go-generated-srcs
+ deps
go: finding module for package github.com/stackrox/rox/pkg/buildinfo
^Cmake: *** [deps] Interrupt: 2

➜  helmtest git:(main) ✗ sb
Switched to branch 'mc/makefile-path-fix'
Your branch is up to date with 'origin/mc/makefile-path-fix'.
➜  helmtest git:(mc/makefile-path-fix) ✗ PATH="/foo bar/bin:/usr/local/bin:/bin:/usr/bin" make go-generated-srcs
+ deps
go: finding module for package github.com/stackrox/rox/pkg/buildinfo
^Cmake: *** [deps] Interrupt: 2

@mtesseract mtesseract requested a review from misberner October 19, 2022 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant