Fix nil pointer dereference in pdbminavailable check #1043
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pdbminavailable check crashed with a panic when it encountered a PodDisruptionBudget that has spec.minAvailable defined but is missing the required spec.selector field. The code attempted to access pdb.Spec.Selector.MatchLabels and pdb.Spec.Selector.MatchExpressions without checking if Selector was nil, causing a nil pointer dereference. This fix adds a nil check for pdb.Spec.Selector before accessing its fields. If the selector is missing, the check now returns a clear diagnostic message with a link to Kubernetes documentation instead of panicking. Also added a unit test TestPDBWithMinAvailableButNoSelector to verify the fix handles this edge case correctly. Fixes #1041 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
rhybrillou
approved these changes
Oct 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pdbminavailable check crashed with a panic when it encountered a PodDisruptionBudget that has spec.minAvailable defined but is missing the required spec.selector field.
The code attempted to access pdb.Spec.Selector.MatchLabels and pdb.Spec.Selector.MatchExpressions without checking if Selector was nil, causing a nil pointer dereference.
This fix adds a nil check for pdb.Spec.Selector before accessing its fields. If the selector is missing, the check now returns a clear diagnostic message with a link to Kubernetes documentation instead of panicking.
Also added a unit test TestPDBWithMinAvailableButNoSelector to verify the fix handles this edge case correctly.
Fixes #1041
🤖 Generated with Claude Code