fix: remove darwin shell hack in Makefile #810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Raad Haddad <raadfhaddad@gmail.com> Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>
janisz
force-pushed
the
remove_shell_hack_for_darwin
branch
from
64649a0
to
abe3384
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #810 +/- ##
===========================================
- Coverage 72.37% 62.36% -10.02%
===========================================
Files 45 197 +152
Lines 1937 4854 +2917
===========================================
+ Hits 1402 3027 +1625
- Misses 421 1439 +1018
- Partials 114 388 +274
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
dhaus67
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes setting a
SHELLas we no longer need it since we simplified our build process and call binaries with full path. The only places whereGOBINneed to be passed is withgo installand can be inlined without need to change it in shell.