Jv update collector config protobuf #13608
Draft
+27
−27
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It was suggested in the PR to set collector runtime config via helm charts that
networking.external_ips.enable
should be changed tonetworking.external_ips.enabled
. The protobuf definitions tend to use enabled rather than enable. The same is true for the helm charts. These protobufs are internal and the feature that uses them is in technical preview. The collector expects the field to beenable
rather thanenabled
in the collector-config ConfigMap. Some customers may have this setting, but as stated earlier this is in technical preview, use in production is not recommended, and customers should not expect this to be stable.This also sets defaults for the collector runtime config fields.
User-facing documentation
Testing and quality
Automated testing
How I validated my change
change me!