Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jv update collector config protobuf #13608

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

JoukoVirtanen
Copy link
Contributor

Description

It was suggested in the PR to set collector runtime config via helm charts that networking.external_ips.enable should be changed to networking.external_ips.enabled. The protobuf definitions tend to use enabled rather than enable. The same is true for the helm charts. These protobufs are internal and the feature that uses them is in technical preview. The collector expects the field to be enable rather than enabled in the collector-config ConfigMap. Some customers may have this setting, but as stated earlier this is in technical preview, use in production is not recommended, and customers should not expect this to be stable.

This also sets defaults for the collector runtime config fields.

User-facing documentation

  • CHANGELOG is updated OR update is not needed
  • documentation PR is created and is linked above OR is not needed

Testing and quality

  • the change is production ready: the change is GA or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

change me!

@rhacs-bot
Copy link
Contributor

rhacs-bot commented Dec 16, 2024

Images are ready for the commit at f2b8ed2.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.7.x-295-gf2b8ed2647.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants