ROX-27391: Update Workload CVE page title with dynamic string #13616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
dvail
changed the base branch from
master
to
dv/ROX-27390-add-workload-cve-view-context
|
Images are ready for the commit at bb4b2b4. To use with deploy scripts, first |
| @@ -161,11 +163,11 @@ function NamespaceViewPage() { | |||
|
|
|||
| return ( | |||
| <> | |||
| <PageTitle title="Workload CVEs - Namespace view" /> | |||
| <PageTitle title={`${pageTitle} - Namespace view`} /> | |||
There was a problem hiding this comment.
Aha, we will need to double down on separation of subroute after information architecture is clearer?
There was a problem hiding this comment.
Likely yes. From what I can tell, the "Platform Components" filter does work with the queries on the namespace route, so separate routes for both user and platform level workloads should be supported. I'll have to confirm with the team that this is what we want.
pedrottimark
approved these changes
Dec 16, 2024
dvail
force-pushed
the
dv/ROX-27390-add-workload-cve-view-context
branch
from
df34593 to
aefbcb7
Compare
dvail
force-pushed
the
dv/ROX-27391-update-page-title-with-dynamic-strings
branch
from
e62ee1b to
bb4b2b4
Compare
Base automatically changed from
dv/ROX-27390-add-workload-cve-view-context
to
master
December 17, 2024 18:51
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Instead of a hard coded "Workload CVEs", reads the page title and breadcrumb navigation link string from the page context.
User-facing documentation
Testing and quality
Automated testing
How I validated my change
Navigate through Workload CVE pages and ensure the page title and breadcrumb link continue to read "Workload CVEs".
