-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
runtime error handling #379
Conversation
c93895b
to
0b7ea52
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #379 +/- ##
==========================================
- Coverage 86.26% 86.19% -0.08%
==========================================
Files 43 44 +1
Lines 19316 19406 +90
Branches 19316 19406 +90
==========================================
+ Hits 16663 16727 +64
- Misses 1182 1214 +32
+ Partials 1471 1465 -6 ☔ View full report in Codecov by Sentry. |
84e00dc
to
84467d9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code changes look good, some changes suggested.
Also, i have been working on converting the lib_test tests to crosscheck tests in the new style, without macros. Is it necessary to use this test method for some reason or could we convert them to the new style?
@krl Regarding your question about |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think merging anything that ignores more than a few tests is not a good idea.
The reason for using anonymous errors in the first place was because they use different error enums, unifying them first would be better, if we're going this route.
84e3959
to
177b751
Compare
2c0b250
to
dc3a132
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work here!
Implements #104
Runtime errors have uncovered issues that are being tracked. Some related tests are currently being ignored.
To simplify this PR review, all necessary changes to address these issues will be handled in a separate work after this PR is merged.