feat: Query By Recipient #1125
Open
feat: Query By Recipient #1125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AshtonStephens
force-pushed
the
query-deposits-by-recipient
branch
from
3e3ac32 to
bf7315b
Compare
AshtonStephens
added
the
emily
AshtonStephens
changed the title
MCJOHN974
reviewed
Dec 20, 2024
| pub next_token: Option<String>, | ||
| /// Maximum number of results to show. | ||
| #[serde(skip_serializing_if = "Option::is_none")] | ||
| pub page_size: Option<i32>, |
There was a problem hiding this comment.
Why page_size is i32 and not u32? From "Maximum number of results to show." description I expect that negative values don't make any sense
MCJOHN974
reviewed
Dec 20, 2024
| @@ -314,7 +324,7 @@ async fn get_deposits() { | |||
| // If the number of elements is an exact multiple of the chunk size the "final" | |||
| // query will still have a next token, and the next query will now have a next | |||
| // token and will return no additional data. | |||
| let expected_chunks = expected_deposit_infos.len() as i32 / chunksize + 1; | |||
| let expected_chunks: i32 = expected_deposit_infos.len() as i32 / chunksize + 1; | |||
There was a problem hiding this comment.
And here as well, should it be u32 instead i32?
MCJOHN974
reviewed
Dec 20, 2024
| } | ||
|
|
||
| // The size of the chunks to grab from the api. | ||
| let chunksize: i32 = 2; |
There was a problem hiding this comment.
And here also probably u32 can work
Jiloc
reviewed
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #1122
Changes
This PR adds a new endpoint to emily. Unfortunately, the client autogeneration stopped working when I made the status optional in the
get_depositsquery, and I couldn't find any autogenerated solution, so to resolve this I've added a new endpoint:https://{base_url}/deposit/recipient/{recipient}.It works much like the other query but has the recipient in the path. This is a departure from the rest implementation, but it's the only way I could get it working.
In order to support this, there's now a new deposit table index that can be accessed by recipient.
Testing Information
Tested with an integration test in this PR.
Checklist: