-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] return a proper errors instead of debug asserts #1165
Conversation
I will replace other |
Before replacing them, try to figure out whether we should just remove them instead. That's a little harder to do, but give it a shot. |
With all this changes we will have only one sbtc/signer/src/bitcoin/validation.rs Line 374 in e4c6b5f
Since the function where it is located do not return a |
@djordon thanks for your comments! I think last commit fixes issues you mentioned |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I just had one rewording comment.
Co-authored-by: Daniel Jordon <djordon@users.noreply.github.com>
Description
Closes: #1164
Changes
Testing Information
Checklist: