Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: additional logging for new_block handler #1203

Merged
merged 7 commits into from
Jan 14, 2025

Conversation

cylewitruk
Copy link
Member

Description

Adds a little additional logging to the new_block event observer handler to help with healthchecks of partner signers. This will now record the block hash, height, parent and bitcoin anchor for log events within the handler.

Changes

  • Additional logging and tracing spans
  • Minor refactors to help optimize how/when the log lines are written and so they include the relevant fields

Testing Information

Checklist:

  • I have performed a self-review of my code
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@cylewitruk cylewitruk added the sbtc signer binary The sBTC Bootstrap Signer. label Jan 10, 2025
@cylewitruk cylewitruk added this to the sBTC: Nice to have milestone Jan 10, 2025
@cylewitruk cylewitruk self-assigned this Jan 10, 2025
Copy link
Collaborator

@djordon djordon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Had some nits and suggestions.

signer/src/api/new_block.rs Outdated Show resolved Hide resolved
signer/src/api/new_block.rs Outdated Show resolved Hide resolved
signer/src/api/new_block.rs Outdated Show resolved Hide resolved
signer/src/api/new_block.rs Outdated Show resolved Hide resolved
@cylewitruk cylewitruk merged commit 1c964ee into main Jan 14, 2025
4 checks passed
@cylewitruk cylewitruk deleted the feat/event-observer-logging branch January 14, 2025 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sbtc signer binary The sBTC Bootstrap Signer.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants