feat: refactor integration test db instantiation #1206
+148
−308
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The integration-env completely broke for me causing me to be unable to run integration tests locally and I'm not sure what the root cause actually was, but I kept getting a lot of failures with errors that looked like concurrency issues (despite that we're using single-threaded). It seemed to be related to creating databases using a template 🤷
This refactor fixed the issues for me anyway and simplifies the code a bit.
Changes
db_num
.new_test_database()
method is now a bit more streamlined -- I removed the parameters since we never use them, and it's now much simpler/smaller.Testing Information
Checklist: