Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refactor integration test db instantiation #1206

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

cylewitruk
Copy link
Member

@cylewitruk cylewitruk commented Jan 10, 2025

Description

The integration-env completely broke for me causing me to be unable to run integration tests locally and I'm not sure what the root cause actually was, but I kept getting a lot of failures with errors that looked like concurrency issues (despite that we're using single-threaded). It seemed to be related to creating databases using a template 🤷

This refactor fixed the issues for me anyway and simplifies the code a bit.

Changes

  • Now uses a sequence in the database for db_num.
  • The new_test_database() method is now a bit more streamlined -- I removed the parameters since we never use them, and it's now much simpler/smaller.

Testing Information

Checklist:

  • I have performed a self-review of my code
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@cylewitruk cylewitruk added this to the sBTC: Nice to have milestone Jan 10, 2025
@cylewitruk cylewitruk self-assigned this Jan 10, 2025
@cylewitruk cylewitruk changed the title feat: refactor integration test db stuff feat: refactor integration test db instantiation Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Needs Triage
Development

Successfully merging this pull request may close these issues.

1 participant