feat: validate rotate keys contract calls with validated shares #1316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lots of small follow-up modifications
match the new column
queries and simplify the validation check. Also add a test.
djordon
added
sbtc signer binary
cylewitruk
reviewed
Feb 6, 2025
cylewitruk
reviewed
Feb 6, 2025
cylewitruk
reviewed
Feb 6, 2025
matteojug
reviewed
Feb 6, 2025
the started_at from the state machine Id
with the postgres implementation
matteojug
deleted the
1313-validate-rotate-keys-contract-calls-with-validated-shares
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #1313.
This PR introduces a few changes that we had spoken about earlier. Also, it turns out that #1313 was already handled the necessary logic required for #1301, this just adds a test.
Changes
dkg_shares_status_idcolumn to just be an enum. Also rename it todkg_shares_status.verified_at_bitcoin_block_*columns tostarted_at_bitcoin_block_*.dkg_sharestable. This was kinda accidental, if we want it I don't mind adding it back.unverifiedtoverifiedorfailed, no other status transitions are allowed. This allowed for some simplifications.SignerStateMachine::get_encrypted_dkg_sharesfunction now takes a bitcoin block ref for when DKG started. It probably makes more sense to put this information in theSignerStateMachinebut the diff was growing and it looked more complex than the route took here.Testing Information
This PR adds a test for the new behavior of the
revoke_dkg_sharesandverify_dkg_sharesfunctions. It also adds a new test for the validation condition inRotateKeysV1struct.Checklist: