use * in mempool SELECT

stacks-network · Sep 25, 2024 · cdb5394 · cdb5394
1 parent f394e64
commit cdb5394
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 16 deletions.
diff --git a/stackslib/src/core/mempool.rs b/stackslib/src/core/mempool.rs
@@ -2015,21 +2015,7 @@ impl MemPoolDB {
  nonce: u64,
  ) -> Result<Option<MemPoolTxMetadata>, db_error> {
  let sql = format!(
- "SELECT
- txid,
- origin_address,
- origin_nonce,
- sponsor_address,
- sponsor_nonce,
- tx_fee,
- length,
- consensus_hash,
- block_header_hash,
- height,
- accept_time,
- last_known_sponsor_nonce,
- last_known_origin_nonce
- FROM mempool WHERE {0}_address = ?1 AND {0}_nonce = ?2",
+ "SELECT * FROM mempool WHERE {0}_address = ?1 AND {0}_nonce = ?2",
  if is_origin { "origin" } else { "sponsor" }
  );
  let args = params![addr.to_string(), u64_to_sql(nonce)?];

diff --git a/stackslib/src/core/tests/mod.rs b/stackslib/src/core/tests/mod.rs
@@ -1381,7 +1381,7 @@ fn mempool_do_not_replace_tx() {
  .unwrap_err();
  assert!(match err_resp {
  MemPoolRejection::ConflictingNonceInMempool => true,
- _ => false,
+ e => panic!("Failed: {e:?}"),
  });
 
  assert!(MemPoolDB::db_has_tx(&mempool_tx, &prior_txid).unwrap());