-
Notifications
You must be signed in to change notification settings - Fork 721
Feat/synthetic print delegate stx #3503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #3503 +/- ##
============================================
+ Coverage 0.18% 31.05% +30.86%
============================================
Files 298 298
Lines 271851 272236 +385
============================================
+ Hits 512 84549 +84037
+ Misses 271339 187687 -83652
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Hey @pavitthrap I'm trying to test out this branch and running into this build error: |
Just fixed the non-test build! |
jcnelson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
zone117x
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and working as expected at hirosystems/stacks-blockchain-api#1527
Thanks @pavitthrap!
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Description
This PR adds a synthetic print event to the
delegate-stxfunction in thepox-2contract. It does so by means of the special contract handler (defined inspecial.rs).This PR adds 2 tests:
pox_2_tests.rsthat calleddelegate-stxthrough a normal stacks transactionneon_integrations.rsthat sends a btc wire DelegateStx tx, and verifies (a) that the delegation was successful, and (b) that a synthetic print event was emitted.Applicable issues
Additional info (benefits, drawbacks, caveats)
Checklist
docs/rpc/openapi.yamlandrpc-endpoints.mdfor v2 endpoints,event-dispatcher.mdfor new events)clarity-benchmarkingrepobitcoin-tests.yml