Draft: re-attempt mining after blocking_signal flaps #3609
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3609 +/- ##
==========================================
- Coverage 31.23% 31.07% -0.16%
==========================================
Files 298 298
Lines 275069 275063 -6
==========================================
- Hits 85923 85484 -439
- Misses 189146 189579 +433
... and 43 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Closing, in lieu of #3610 |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is attempting to address an issue we're seeing in the Hiro testnet miner related to the miner thread blocking signal. In the current implementation, if a miner attempts to mine and sees the "block" signal, the "RunTenure" command is not reissued. The miner thread does not attempt to mine again, and this results in missed sortitions.
This is still a draft as we're still trying to diagnose the exact locking behavior (we're also seeing chains coordinator thread stalls with db contention, which is magnifying this issue, but it isn't clear year what's driving that).