-
Notifications
You must be signed in to change notification settings - Fork 671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: Replace Hex Encoding/Decoding #4465
base: next
Are you sure you want to change the base?
Chore: Replace Hex Encoding/Decoding #4465
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Smaller improvement than I expected. It's up to Aaron and Jude if they are okay introducing a dependency for this
Might also consider the |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #4465 +/- ##
==========================================
- Coverage 83.46% 78.19% -5.28%
==========================================
Files 448 448
Lines 324321 324311 -10
==========================================
- Hits 270698 253585 -17113
- Misses 53623 70726 +17103
... and 165 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Per the call today, I think we should defer further consideration of this until we remove hex encode/decode from the DB I/O paths (since that's where a lot of this happens, and in this case, we can just remove the hex codec altogether). |
I'll convert this into |
Description
I took a look at the functions that were doing the hex encoding and decoding in the
stacks-common
package and there was an easy replacement with an external crate (faster-hex
) in order to improve the performance. The results show a performance increase of about1%
when processing blocks: