chore(logs): Improve and standardize structured logging (1st Pass) #4949
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR leverages
slog
's features as much as possible to create log messages with plenty of context to help developers debug issues but also end users when running their node without development experience. It also seeks to help settle on a standard for structured logging across the codebase. As an initial effort, only messages on some files have been updated:main.rs
)boot_nakamoto.rs
)sortdb.rs
)Once a standard is defined, it can be propagated in subsequent passes.
Changes
error!
).References
Applicable issues
Checklist
docs/rpc/openapi.yaml
andrpc-endpoints.md
for v2 endpoints,event-dispatcher.md
for new events)clarity-benchmarking
repobitcoin-tests.yml