Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove bad feature gating #5011

Merged
merged 1 commit into from
Jul 25, 2024
Merged

fix: remove bad feature gating #5011

merged 1 commit into from
Jul 25, 2024

Conversation

obycode
Copy link
Contributor

@obycode obycode commented Jul 25, 2024

I noticed this was causing failures in several active PRs. I'm not sure what changed or when to cause this.

@obycode obycode requested a review from a team as a code owner July 25, 2024 18:39
@obycode
Copy link
Contributor Author

obycode commented Jul 25, 2024

Looks like the update from rust 1.79 to 1.80 is the cause.

We do not have a `std` feature, so this causes an error. Before Rust
1.80, this was not an error.
@obycode obycode enabled auto-merge July 25, 2024 18:50
@obycode obycode added this pull request to the merge queue Jul 25, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 25, 2024
@obycode obycode added this pull request to the merge queue Jul 25, 2024
Merged via the queue into develop with commit 9198899 Jul 25, 2024
1 check passed
@obycode obycode deleted the fix-build branch July 25, 2024 20:34
@blockstack-devops
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@stacks-network stacks-network locked as resolved and limited conversation to collaborators Oct 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants