Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add methods to TypeMap #5059

Merged
merged 2 commits into from
Aug 8, 2024

Conversation

krl
Copy link

@krl krl commented Aug 8, 2024

Methods needed to implement typechecker workarounds in clarity-wasm

@krl krl requested a review from a team as a code owner August 8, 2024 09:12
@krl krl force-pushed the clarity-wasm-develop-typemap-patch branch 2 times, most recently from 330dc40 to 3e1554e Compare August 8, 2024 09:33
@krl krl force-pushed the clarity-wasm-develop-typemap-patch branch from 3e1554e to 32366f5 Compare August 8, 2024 09:35
Copy link
Contributor

@Acaccia Acaccia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me, I just have minor remarks. Feel free to ignore them if you find them irrelevant.

clarity/src/vm/analysis/type_checker/contexts.rs Outdated Show resolved Hide resolved
clarity/src/vm/analysis/type_checker/contexts.rs Outdated Show resolved Hide resolved
clarity/src/vm/analysis/type_checker/contexts.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@Acaccia Acaccia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@krl krl merged commit f6fff25 into feat/clarity-wasm-develop Aug 8, 2024
1 check passed
@krl krl deleted the clarity-wasm-develop-typemap-patch branch August 8, 2024 11:35
@blockstack-devops
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@stacks-network stacks-network locked as resolved and limited conversation to collaborators Oct 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants