Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarity-Wasm: throw for arg name already used in function definition #5168

Closed
wants to merge 1 commit into from
Closed

Clarity-Wasm: throw for arg name already used in function definition #5168

wants to merge 1 commit into from

Conversation

matteojug
Copy link

Throw when defining a function with repeated arg name. Tested with stacks-network/clarity-wasm#510.

@matteojug matteojug requested a review from a team as a code owner September 12, 2024 15:32
@matteojug matteojug mentioned this pull request Sep 12, 2024
Merged
Acaccia
Acaccia reviewed Sep 13, 2024
View reviewed changes
Copy link
Contributor

@Acaccia Acaccia left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not think we want to change the type checker to fail on an already used argument. The typechecker doesn't have issues with it in the interpreter. I would just make a change in the compiler here.

@matteojug
Copy link
Author

Closed as per discussion on stacks-network/clarity-wasm#510.

@matteojug matteojug closed this Sep 13, 2024
@matteojug matteojug deleted the fix/clarity-throw-already-used-arg branch September 13, 2024 09:35
@blockstack-devops
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@stacks-network stacks-network locked as resolved and limited conversation to collaborators Oct 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Acaccia Acaccia Acaccia left review comments

@csgui csgui Awaiting requested review from csgui

Assignees
No one assigned
Labels
locked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matteojug @blockstack-devops @Acaccia