Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/5230 #5236

Merged
merged 8 commits into from
Sep 25, 2024
Merged

Fix/5230 #5236

merged 8 commits into from
Sep 25, 2024

Conversation

jcnelson
Copy link
Member

Fixes #5230 by indexing Stacks-on-Bitcoin operations by the tenure-start block ID, instead of each and every Stacks block.

Leaving as a draft for now until I can write more unit tests.

@jcnelson jcnelson changed the base branch from master to develop September 24, 2024 17:36
Copy link
Member

@kantai kantai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me -- will re-review when tests are added.

@jcnelson jcnelson marked this pull request as ready for review September 24, 2024 21:10
@jcnelson jcnelson requested review from a team as code owners September 24, 2024 21:10
kantai
kantai previously approved these changes Sep 24, 2024
Copy link
Contributor

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wileyj wileyj added this pull request to the merge queue Sep 25, 2024
Merged via the queue into develop with commit 447bb15 Sep 25, 2024
1 check passed
@blockstack-devops
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@stacks-network stacks-network locked as resolved and limited conversation to collaborators Oct 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] burn ops are applied multiple times per tenure
7 participants