Fix: Conditional logging for 'Proceeding to mine blocks' message #5338

Parikalp-Bhardwaj · 2024-10-21T12:21:11Z

Summary

This PR fixes an issue where the node logs Proceeding to mine blocks even when running as a follower node. The log message is now conditional on the node being a miner.

Changes

Added a conditional check around the log message to ensure it only appears when the node is configured as a miner.

Related Issues

Closes Node always logs "Proceeding to mine blocks" regardless of miner status #4944

…ch 3 and shutdown the runloop Signed-off-by: Jacinta Ferrant <jacinta@trustmachines.co>

… into chore/fix-multiple-miners

…d update the README file Signed-off-by: Jacinta Ferrant <jacinta@trustmachines.co>

Signed-off-by: Jacinta Ferrant <jacinta@trustmachines.co>

…tate between (and including) the new and old tips, since cached data from the old tip will have stored a negative cache result that ought now to be positive in the context of the new tip.

…og analysis tools

…e-key-leakage Do not leak a private key that has a small typo

… into chore/remove-v1-signer

…tent with no-caching behavior

… into chore/fix-multiple-miners

Chore/remove v1 signer

Chore: Merge master -> develop

Signed-off-by: Jacinta Ferrant <jacinta@trustmachines.co>

… into chore/fix-multiple-miners

…lockchain into fix/5249

Signed-off-by: Jacinta Ferrant <jacinta@trustmachines.co>

…ure_height Include `tenure_height` in `/new_block` event payload

Signed-off-by: Jacinta Ferrant <jacinta@trustmachines.co>

CLAassistant · 2024-10-21T12:21:19Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
8 out of 10 committers have signed the CLA.

✅ kantai
✅ obycode
✅ jcnelson
✅ saralab
✅ aldur
✅ wileyj
✅ Parikalp-Bhardwaj
✅ hstove
❌ jferrant
❌ zone117x
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

obycode

Good idea. Thanks for the PR @Parikalp-Bhardwaj!

Fix partial tenure fork test

hstove · 2024-10-21T14:51:23Z

Should we target this to develop instead of master?

obycode · 2024-10-21T14:52:31Z

Should we target this to develop instead of master?

Yes, good point.

saralab · 2024-10-21T14:58:19Z

@Parikalp-Bhardwaj : This should merge to develop instead of master before we can approve

…ions Add version to signer messages

Chore: Configure signer set to be more permissive about a slow miner wakeup

Chore: Set 3.0 mainnet activation height

obycode · 2024-10-21T20:29:48Z

Replaced with #5348

Fix: Conditional logging for 'Proceeding to mine blocks' message #5338

blockstack-devops · 2024-10-30T00:20:26Z

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

jferrant and others added 30 commits September 26, 2024 14:39

Do not advance unless the bootstrapped or follower node also hits epo…

cd49977

…ch 3 and shutdown the runloop Signed-off-by: Jacinta Ferrant <jacinta@trustmachines.co>

Merge branch 'develop' of https://github.com/stacks-network/stacks-core…

db564e9

… into chore/fix-multiple-miners

Remove stale functions and config options left over from v1 signer an…

04c6c8a

…d update the README file Signed-off-by: Jacinta Ferrant <jacinta@trustmachines.co>

Do not leak a private key that has a small typo

ff58018

Signed-off-by: Jacinta Ferrant <jacinta@trustmachines.co>

Test: try increasing a timeout to see what CI does

c60e4a6

Signed-off-by: Jacinta Ferrant <jacinta@trustmachines.co>

fix: /v3/sortitions over optimistic in finding last sortition

0feddea

fix: tenure extend logic. only include tx in first block after extension

8809f91

feat: helper method to get the tenure ID for a block

a5b5f29

feat: tool for generating invs for nakamoto testnet

475ed44

fix: when advancing the tip height, invalidate all cached inventory s…

d70c223

…tate between (and including) the new and old tips, since cached data from the old tip will have stored a negative cache result that ought now to be positive in the context of the new tip.

chore: API sync

61713ca

add Nakamoto block heights to info logs for easier integration with l…

9598565

…og analysis tools

Merge pull request #5250 from stacks-network/bugfix/accidental-privat…

9c90c5c

…e-key-leakage Do not leak a private key that has a small typo

Merge branch 'master' into chore/master-develop-093024

419801b

chore: fix merge artifacts

5327a59

Merge branch 'develop' of https://github.com/stacks-network/stacks-core…

8c0137c

… into chore/remove-v1-signer

chore: expand test coverage to verify that caching behavior is consis…

cc326c4

…tent with no-caching behavior

Merge branch 'develop' of https://github.com/stacks-network/stacks-core…

28d06b7

… into chore/fix-multiple-miners

Merge branch 'develop' into fix/5249

4449852

ci: "at least" means >=, not > in tests

d805368

Merge branch 'develop' into feat/naka-miner-heuristics

f271794

Merge pull request #5243 from stacks-network/chore/remove-v1-signer

a50f955

Chore/remove v1 signer

fix: need interim blocks in the nakamoto integration tests

8b36b88

Merge pull request #5258 from stacks-network/chore/master-develop-093024

18c70b4

Chore: Merge master -> develop

Do not wait for an exact number of block rejections

9c89e46

Signed-off-by: Jacinta Ferrant <jacinta@trustmachines.co>

Merge branch 'develop' into fix/testnet-launch-fixes

2875d45

Merge branch 'develop' of https://github.com/stacks-network/stacks-core…

065a89b

… into chore/fix-multiple-miners

chore: document cache maintenance

b461394

Merge branch 'fix/5249' of https://github.com/stacks-network/stacks-b…

340b649

…lockchain into fix/5249

Add some logging to bitcoind test

fdcfcdf

Signed-off-by: Jacinta Ferrant <jacinta@trustmachines.co>

hstove and others added 6 commits October 18, 2024 16:54

feat: add signer message metadata to block responses

5f4c42f

feat: add metadata to mock signatures

a1208c8

Merge pull request #5333 from stacks-network/feat/new_block_event_ten…

76b3094

…ure_height Include `tenure_height` in `/new_block` event payload

Do not assume every tenure has inter_blocks_per_tenure

899ff22

Signed-off-by: Jacinta Ferrant <jacinta@trustmachines.co>

fix: use hex instead of u8 bytes in fixture

9f9ad40

Fix: Conditional logging for 'Proceeding to mine blocks' message

706806f

Parikalp-Bhardwaj requested a review from a team as a code owner October 21, 2024 12:21

obycode previously approved these changes Oct 21, 2024

View reviewed changes

obycode requested a review from a team October 21, 2024 13:07

Merge pull request #5337 from stacks-network/fix/partial-tenure-fork

da15d83

Fix partial tenure fork test

saralab closed this Oct 21, 2024

saralab reopened this Oct 21, 2024

jferrant and others added 6 commits October 21, 2024 15:56

Merge pull request #5336 from stacks-network/feat/signer-message-vers…

ca84a1b

…ions Add version to signer messages

chore: signers should be more permissive about a slow miner wakeup

5ae2906

Merge pull request #5341 from stacks-network/chore/naka-configs

1528a57

Chore: Configure signer set to be more permissive about a slow miner wakeup

chore: set 3.0 mainnet activation height

cc8bddc

Merge pull request #5345 from stacks-network/chore/set-3.0-height

5f1b6b9

Chore: Set 3.0 mainnet activation height

Merge branch 'develop' into fix-log-message

183a5ce

obycode dismissed their stale review via 183a5ce October 21, 2024 20:29

obycode requested a review from a team as a code owner October 21, 2024 20:29

obycode closed this Oct 21, 2024

github-merge-queue bot pushed a commit that referenced this pull request Oct 23, 2024

Merge pull request #5348 from Parikalp-Bhardwaj/fix-log-message

f299dd1

Fix: Conditional logging for 'Proceeding to mine blocks' message #5338

blockstack-devops added the locked label Oct 30, 2024

stacks-network locked as resolved and limited conversation to collaborators Oct 30, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix: Conditional logging for 'Proceeding to mine blocks' message #5338

Fix: Conditional logging for 'Proceeding to mine blocks' message #5338

Parikalp-Bhardwaj commented Oct 21, 2024 •

edited

Loading

CLAassistant commented Oct 21, 2024 •

edited

Loading

obycode left a comment

hstove commented Oct 21, 2024

obycode commented Oct 21, 2024

saralab commented Oct 21, 2024

obycode commented Oct 21, 2024

blockstack-devops commented Oct 30, 2024

Fix: Conditional logging for 'Proceeding to mine blocks' message #5338

Fix: Conditional logging for 'Proceeding to mine blocks' message #5338

Conversation

Parikalp-Bhardwaj commented Oct 21, 2024 • edited Loading

Summary

Changes

Related Issues

CLAassistant commented Oct 21, 2024 • edited Loading

obycode left a comment

Choose a reason for hiding this comment

hstove commented Oct 21, 2024

obycode commented Oct 21, 2024

saralab commented Oct 21, 2024

obycode commented Oct 21, 2024

blockstack-devops commented Oct 30, 2024

Parikalp-Bhardwaj commented Oct 21, 2024 •

edited

Loading

CLAassistant commented Oct 21, 2024 •

edited

Loading