Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/sip29 testnet config #5520

Merged
merged 6 commits into from
Dec 4, 2024
Merged

Feat/sip29 testnet config #5520

merged 6 commits into from
Dec 4, 2024

Conversation

rdeioris
Copy link
Contributor

@rdeioris rdeioris commented Dec 2, 2024 •
edited
Loading

Description

Allows configuration for epoch 3.1 (for sip-029)

Applicable issues

  • fixes #

Additional info (benefits, drawbacks, caveats)

Checklist

  • Test coverage for new or modified code paths
  • Changelog is updated
  • Required documentation changes (e.g., docs/rpc/openapi.yaml and rpc-endpoints.md for v2 endpoints, event-dispatcher.md for new events)
  • New clarity functions have corresponding PR in clarity-benchmarking repo
  • New integration test(s) added to bitcoin-tests.yml

@wileyj
Copy link
Contributor

wileyj commented Dec 3, 2024

pushing some cherry-picked commits from develop that get past the clippy build erros

@aldur aldur requested a review from hstove December 3, 2024 15:46
hstove
hstove approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@hstove hstove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aldur aldur marked this pull request as ready for review December 3, 2024 22:59
@aldur aldur requested review from a team as code owners December 3, 2024 22:59
obycode
obycode approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aldur aldur merged commit 45383fc into feat/sip-029 Dec 4, 2024
1 check passed
@blockstack-devops
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@stacks-network stacks-network locked as resolved and limited conversation to collaborators Dec 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@obycode obycode obycode approved these changes

@hstove hstove hstove approved these changes

Assignees
No one assigned
Labels
locked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rdeioris @wileyj @blockstack-devops @hstove @obycode @aldur