-
Notifications
You must be signed in to change notification settings - Fork 677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: test for idle extend with active mining #5531
feat: test for idle extend with active mining #5531
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add the new test to bitcoin-tests.yml?
@obycode good catch, fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. Just had some small comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Adds a test for tenure extends happening after the idle timeout when there is active mining involved. This test ensure that multiple extends occur within a single tenure (BTC block) after each idle timeout is reached.
I've added some test helpers in here, mainly because I was over writing the same boilerplate for certain things. I didn't want to change other tests too much to limit the diff, but I'm happy to.