Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: test for idle extend with active mining #5531

Merged
merged 4 commits into from
Dec 4, 2024

Conversation

hstove
Copy link
Contributor

@hstove hstove commented Dec 4, 2024

Adds a test for tenure extends happening after the idle timeout when there is active mining involved. This test ensure that multiple extends occur within a single tenure (BTC block) after each idle timeout is reached.

I've added some test helpers in here, mainly because I was over writing the same boilerplate for certain things. I didn't want to change other tests too much to limit the diff, but I'm happy to.

@hstove hstove requested review from a team as code owners December 4, 2024 02:12
@hstove hstove requested review from obycode and jferrant December 4, 2024 02:12
@hstove hstove linked an issue Dec 4, 2024 that may be closed by this pull request
4 tasks
Copy link
Contributor

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the new test to bitcoin-tests.yml?

@hstove hstove requested a review from a team as a code owner December 4, 2024 16:22
@hstove hstove requested a review from obycode December 4, 2024 16:23
@hstove
Copy link
Contributor Author

hstove commented Dec 4, 2024

@obycode good catch, fixed

Copy link
Contributor

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Just had some small comments.

Copy link
Contributor

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hstove hstove requested review from obycode and jferrant December 4, 2024 17:16
@obycode obycode merged commit 805a379 into feat/time-based-tenure-extend Dec 4, 2024
1 check passed
@obycode obycode deleted the feat/active-mining-idle-test branch December 4, 2024 18:05
@blockstack-devops
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@stacks-network stacks-network locked as resolved and limited conversation to collaborators Dec 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write integration tests for time-based tenure extensions
4 participants