Feat/SIP029-testnet-heights #5537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcnelson
changed the title
jbencin
previously approved these changes
Dec 6, 2024
|
Yes it would. This PR isn't trying to do this though. Did I put in bad
numbers?
…On Fri, Dec 6, 2024, 3:56 PM Jeff Bencin ***@***.***> wrote:
***@***.**** approved this pull request.
Changing coinbase rewards on already mined blocks would break consensus on
existing testnets, wouldn't it? I guess it's not a problem because we can
just restart the testnets, right?
—
Reply to this email directly, view it on GitHub
<#5537 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADQJK3X5IZGSCM5CLTPMGT2EIFQHAVCNFSM6AAAAABTFLQQTCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDIOBVHA3TSMJQHA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
obycode
previously approved these changes
Dec 6, 2024
wileyj
approved these changes
Dec 9, 2024
obycode
approved these changes
Dec 9, 2024
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sets the primary testnet activation heights for SIP-029, as well as the primary testnet halvening schedule.