Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Apply Clippy vec_init_then_push, map_clone, map_entry, and iter_* lints #5656

Merged

Conversation

jbencin
Copy link
Contributor

@jbencin jbencin commented Jan 5, 2025

Description

Apply Clippy vec_init_then_push and iter_* lints. Specifically:

@jbencin jbencin requested a review from a team as a code owner January 5, 2025 05:08
@jbencin jbencin changed the title Chore: Apply Clippy vec_init_then_push and iter_* lints chore: Apply Clippy vec_init_then_push, map_clone, and iter_* lints Jan 5, 2025
@jbencin jbencin changed the title chore: Apply Clippy vec_init_then_push, map_clone, and iter_* lints chore: Apply Clippy vec_init_then_push, map_clone, map_entry, and iter_* lints Jan 5, 2025
obycode
obycode previously approved these changes Jan 6, 2025
Copy link
Contributor

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

jferrant
jferrant previously approved these changes Jan 8, 2025
Copy link
Collaborator

@jferrant jferrant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NOICE :D

@jbencin jbencin added this pull request to the merge queue Jan 8, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 8, 2025
@jbencin jbencin added this pull request to the merge queue Jan 8, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 8, 2025
@jbencin jbencin dismissed stale reviews from jferrant and obycode via bab1182 January 10, 2025 15:04
@jbencin jbencin requested review from jferrant and obycode January 10, 2025 15:05
@kantai kantai added the lint Related to linting/clippy/cargo warns label Jan 17, 2025
jferrant
jferrant previously approved these changes Jan 22, 2025
@jbencin jbencin enabled auto-merge January 22, 2025 17:59
@CLAassistant
Copy link

CLAassistant commented Jan 22, 2025

CLA assistant check
All committers have signed the CLA.

obycode
obycode previously approved these changes Jan 22, 2025
@jbencin jbencin dismissed stale reviews from obycode and jferrant via 872a1cf January 23, 2025 15:54
@jbencin jbencin requested a review from jferrant January 23, 2025 15:54
@jbencin jbencin requested a review from obycode January 23, 2025 15:54
@jbencin jbencin added this pull request to the merge queue Jan 23, 2025
Merged via the queue into stacks-network:develop with commit c147821 Jan 23, 2025
2 checks passed
@jbencin jbencin deleted the chore/clippy-vec-and-iter-lints branch January 23, 2025 20:57
@blockstack-devops
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@stacks-network stacks-network locked as resolved and limited conversation to collaborators Jan 31, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lint Related to linting/clippy/cargo warns locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants