Skip to content

Conversation

@fdefelici
Copy link
Contributor

@fdefelici fdefelici commented Sep 18, 2025

Description

This PR is a follow-up to #6254 (related discussion)
It removes the unused mutation-testing script from the contrib/ folder, along with the associated documentation.

Applicable issues

Additional info (benefits, drawbacks, caveats)

Checklist

  • Test coverage for new or modified code paths
  • Changelog is updated
  • Required documentation changes (e.g., docs/rpc/openapi.yaml and rpc-endpoints.md for v2 endpoints, event-dispatcher.md for new events)
  • New clarity functions have corresponding PR in clarity-benchmarking repo
  • New integration test(s) added to bitcoin-tests.yml

@fdefelici
Copy link
Contributor Author

@wileyj Since mutation-testing is being completely removed, I could also include in this PR:

  • Removing all #[cfg_attr(test, mutation::skip)] tags from the codebase
  • Dropping the mutant crate dependency
  • Closing all GitHub issues (referenced in the codebase) related to mutation-testing

What do you think?

@fdefelici fdefelici self-assigned this Sep 18, 2025
@fdefelici fdefelici added the chore Necessary but less impactful tasks such as cleanup or reorg label Sep 18, 2025
@fdefelici fdefelici moved this to Status: 💻 In Progress in Stacks Core Eng Sep 18, 2025
@fdefelici fdefelici added this to the 3.2.0.0.2 milestone Sep 18, 2025
@fdefelici fdefelici linked an issue Sep 18, 2025 that may be closed by this pull request
@fdefelici
Copy link
Contributor Author

@wileyj Since mutation-testing is being completely removed, I could also include in this PR:

  • Removing all #[cfg_attr(test, mutation::skip)] tags from the codebase
  • Dropping the mutant crate dependency
  • Closing all GitHub issues (referenced in the codebase) related to mutation-testing

What do you think?

As shared during the nakasync, we’ll just update the documentation and remove the script from the contrib/ folder, while keeping the rest for potential future use.

@fdefelici fdefelici moved this from Status: 💻 In Progress to Status: In Review in Stacks Core Eng Sep 19, 2025
@fdefelici fdefelici requested a review from wileyj September 19, 2025 05:57
@fdefelici fdefelici marked this pull request as ready for review September 19, 2025 05:57
@fdefelici fdefelici requested review from a team as code owners September 19, 2025 05:57
Copy link
Collaborator

@wileyj wileyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-project-automation github-project-automation bot moved this from Status: In Review to Status: 💻 In Progress in Stacks Core Eng Sep 19, 2025
@fdefelici fdefelici added this pull request to the merge queue Sep 22, 2025
Merged via the queue into stacks-network:develop with commit 88058ef Sep 22, 2025
1 of 2 checks passed
@fdefelici fdefelici deleted the chore/remove-contrib-mutation-testing branch September 22, 2025 07:37
@github-project-automation github-project-automation bot moved this from Status: 💻 In Progress to Status: ✅ Done in Stacks Core Eng Sep 22, 2025
@codecov
Copy link

codecov bot commented Sep 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.50%. Comparing base (49727a3) to head (7ad4042).
⚠️ Report is 28 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6512      +/-   ##
===========================================
- Coverage    80.03%   79.50%   -0.53%     
===========================================
  Files          565      565              
  Lines       346446   346446              
===========================================
- Hits        277282   275458    -1824     
- Misses       69164    70988    +1824     

see 65 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49727a3...7ad4042. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

chore Necessary but less impactful tasks such as cleanup or reorg locked

Projects

Status: Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

chore: remove mutation-testing from contrib

3 participants