Skip to content

Conversation

@jferrant
Copy link
Contributor

@jferrant jferrant commented Oct 14, 2025

I am investigating the conversion of ChainstateError::{Error variant} to ChainstateError::InvalidStacksBlock(String) and I noticed these is_wellformed_* fns were written with an empty error and were all being mapped to ChainstateError::InvalidStacksBlock(String) with slightly different String messages so I made them return a consistent InvalidStacksBlock error and removed some redundant checks in validate_transactions_static

…ersions

Signed-off-by: Jacinta Ferrant <jacinta.ferrant@gmail.com>
Copy link
Contributor

@federico-stacks federico-stacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT!

Copy link
Contributor

@Jiloc Jiloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@jferrant jferrant added this pull request to the merge queue Oct 16, 2025
Merged via the queue into stacks-network:develop with commit a92b29a Oct 16, 2025
3 of 4 checks passed
@jferrant jferrant deleted the chore/cleanup-wellformed-tenure-fns branch October 16, 2025 19:35
@codecov
Copy link

codecov bot commented Oct 16, 2025

Codecov Report

❌ Patch coverage is 90.90909% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.09%. Comparing base (c5cca10) to head (8aa9641).
⚠️ Report is 35 commits behind head on develop.

Files with missing lines Patch % Lines
stackslib/src/chainstate/nakamoto/mod.rs 81.39% 8 Missing ⚠️
contrib/stacks-inspect/src/lib.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6600      +/-   ##
===========================================
- Coverage    79.58%   79.09%   -0.50%     
===========================================
  Files          571      571              
  Lines       351593   351573      -20     
===========================================
- Hits        279823   278062    -1761     
- Misses       71770    73511    +1741     
Files with missing lines Coverage Δ
...tackslib/src/chainstate/nakamoto/staging_blocks.rs 89.56% <ø> (+2.44%) ⬆️
stackslib/src/chainstate/nakamoto/tests/mod.rs 99.13% <100.00%> (+<0.01%) ⬆️
stackslib/src/net/tests/download/nakamoto.rs 95.57% <100.00%> (+0.18%) ⬆️
contrib/stacks-inspect/src/lib.rs 19.87% <0.00%> (+0.07%) ⬆️
stackslib/src/chainstate/nakamoto/mod.rs 83.49% <81.39%> (+0.31%) ⬆️

... and 57 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5cca10...8aa9641. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants