-
Notifications
You must be signed in to change notification settings - Fork 715
Make is_wellformed_tenure_*_block return Error and remove custom conversions #6600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make is_wellformed_tenure_*_block return Error and remove custom conversions #6600
Conversation
…ersions Signed-off-by: Jacinta Ferrant <jacinta.ferrant@gmail.com>
federico-stacks
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT!
Jiloc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
a92b29a
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6600 +/- ##
===========================================
- Coverage 79.58% 79.09% -0.50%
===========================================
Files 571 571
Lines 351593 351573 -20
===========================================
- Hits 279823 278062 -1761
- Misses 71770 73511 +1741
... and 57 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
I am investigating the conversion of
ChainstateError::{Error variant}toChainstateError::InvalidStacksBlock(String)and I noticed theseis_wellformed_*fns were written with an empty error and were all being mapped toChainstateError::InvalidStacksBlock(String)with slightly different String messages so I made them return a consistentInvalidStacksBlockerror and removed some redundant checks invalidate_transactions_static