Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIP-021: Nakamoto v1 #155

Merged
merged 43 commits into from
Jul 25, 2024
Merged

SIP-021: Nakamoto v1 #155

merged 43 commits into from
Jul 25, 2024

Conversation

jcnelson
Copy link
Contributor

@jcnelson jcnelson commented Oct 2, 2023

This is the SIP that describes the Nakamoto v1 system. It implements fast and reliable blocks, and must be implemented before sBTC.

I've styled this SIP-021. In my mind, it supersedes the existing SIP-021.

@jcnelson jcnelson mentioned this pull request Oct 2, 2023
@jferrant
Copy link

jferrant commented Oct 2, 2023

Very minor comments on my part :D Great to see this update!

Copy link

@setzeus setzeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still only ~halfway through but very detailed & informative. Only came across one typo so far.

sips/sip-021/sip-021-nakamoto.md Outdated Show resolved Hide resolved
Copy link
Contributor

@diwakergupta diwakergupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of my comments are non-blocking. Thanks for writing this up Jude!!

sips/sip-021/sip-021-nakamoto.md Outdated Show resolved Hide resolved
sips/sip-021/sip-021-nakamoto.md Outdated Show resolved Hide resolved
sips/sip-021/sip-021-nakamoto.md Outdated Show resolved Hide resolved
sips/sip-021/sip-021-nakamoto.md Outdated Show resolved Hide resolved
sips/sip-021/sip-021-nakamoto.md Outdated Show resolved Hide resolved
sips/sip-021/sip-021-nakamoto.md Outdated Show resolved Hide resolved
sips/sip-021/sip-021-nakamoto.md Outdated Show resolved Hide resolved
sips/sip-021/sip-021-nakamoto.md Outdated Show resolved Hide resolved
sips/sip-021/sip-021-nakamoto.md Outdated Show resolved Hide resolved
sips/sip-021/sip-021-nakamoto.md Outdated Show resolved Hide resolved
sips/sip-021/sip-021-nakamoto.md Outdated Show resolved Hide resolved
sips/sip-021/sip-021-nakamoto.md Outdated Show resolved Hide resolved
sips/sip-021/sip-021-nakamoto.md Outdated Show resolved Hide resolved
sips/sip-021/sip-021-nakamoto.md Outdated Show resolved Hide resolved
sips/sip-021/sip-021-nakamoto.md Outdated Show resolved Hide resolved
Copy link

@CharlieC3 CharlieC3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only minor things, great job on this Jude as usual!

sips/sip-021/sip-021-nakamoto.md Outdated Show resolved Hide resolved
sips/sip-021/sip-021-nakamoto.md Outdated Show resolved Hide resolved
sips/sip-021/sip-021-nakamoto.md Outdated Show resolved Hide resolved
sips/sip-021/sip-021-nakamoto.md Outdated Show resolved Hide resolved
sips/sip-021/sip-021-nakamoto.md Outdated Show resolved Hide resolved
sips/sip-021/sip-021-nakamoto.md Outdated Show resolved Hide resolved
Copy link
Contributor

@friedger friedger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added more changes to pox-4 contract.

sips/sip-021/sip-021-nakamoto.md Outdated Show resolved Hide resolved
sips/sip-021/sip-021-nakamoto.md Outdated Show resolved Hide resolved
obycode and others added 2 commits April 11, 2024 10:22
Co-authored-by: Mårten Blankfors <marten@blankfors.se>
@obycode
Copy link
Contributor

obycode commented May 7, 2024

This SIP was also approved by the Economics CAB. See meeting minutes here

obycode
obycode previously approved these changes May 8, 2024
@obycode
Copy link
Contributor

obycode commented May 8, 2024

Gina, @jcnelson, or @MarvinJanssen -- can we get a sing-off sign-off from the steering committee added, then we should be ready to merge!

EDIT: fixed typo, but you three can do a sing-off if you want 😆

…v files enclosed for solo, pool and dao voting results respectively.
@wileyj wileyj requested a review from jiga July 3, 2024 18:05
Copy link

@jiga jiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approval from SIP Editors

obycode
obycode previously approved these changes Jul 8, 2024
Copy link
Contributor

@Hero-Gamer Hero-Gamer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logging Nakamoto Community Voting Results

sips/sip-021/sip-021-nakamoto.md Show resolved Hide resolved
sips/sip-021/sip-021-nakamoto.md Show resolved Hide resolved
sips/sip-021/sip-021-nakamoto.md Outdated Show resolved Hide resolved
sips/sip-021/sip-021-nakamoto.md Show resolved Hide resolved
@wileyj wileyj requested review from jiga and Hero-Gamer July 24, 2024 05:44
@wileyj wileyj requested a review from obycode July 24, 2024 14:25
@whoabuddy whoabuddy self-requested a review July 25, 2024 12:07
Copy link
Member

@whoabuddy whoabuddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work everyone!

@whoabuddy whoabuddy merged commit 378ad16 into main Jul 25, 2024
@whoabuddy whoabuddy changed the title SIP: Nakamoto v1 SIP-021: Nakamoto v1 Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.