Fix #45 and making it possible to only import the parse method #65
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it's possible to partially import the parse method from errorStackParser, the
this
invokation will be wrong as currently the parent object is not explicetly bound to the parse method (and all other methods). So something like this fails:with following error:
TypeError: Cannot read property 'parseV8OrIE' of undefined
Description
I created an errorStackParser object, added .bind(errorStackParser) to all methods and returned this obj.
Motivation and Context
See description
#45
How Has This Been Tested?
Types of changes
Checklist:
node_modules/.bin/jscs -c .jscsrc error-stack-parser.js
passes without errorsnpm test
passes without errors