Skip to content

Update types to reflect issue#45 #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 5, 2022

Conversation

alessioprestileo
Copy link
Contributor

The parse function should not be imported by itself. Types were updated accordingly.

Description

The parse function should not be imported by itself, as explained in issue#45. The issue arises because the types allow the parse function to be imported by itself, as a named export.
I changed the types so that the only possible import is the default export, like
import ErrorStackParser from 'error-stack-parser';
and the parse function can only be used like
ErrorStackParser.parse(error)

Motivation and Context

This PR updates the types so that Issue #45 cannot occur, because the parse function cannot be imported by itself.

How Has This Been Tested?

I tested the new types in a repo where I use error-stack-parser.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • node_modules/.bin/jscs -c .jscsrc error-stack-parser.js passes without errors
  • npm test passes without errors
  • I have read the contribution guidelines
  • I have updated the documentation accordingly
  • I have added tests to cover my changes

The parse function should not be imported by itself. Types were updated accordingly.
@alessioprestileo
Copy link
Contributor Author

@eriwen
Hello, do you have any feedback on this PR?

@eriwen eriwen merged commit 97b30d1 into stacktracejs:master Jun 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants