Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct missing eo:cloud_cover values #91

Merged
merged 3 commits into from
Jan 19, 2023
Merged

Correct missing eo:cloud_cover values #91

merged 3 commits into from
Jan 19, 2023

Conversation

pjhartzell
Copy link
Contributor

@pjhartzell pjhartzell commented Jan 19, 2023 •
edited
Loading

Related Issue(s):

Description:

  • Fixes bug where eo:cloud_cover was not assigned to the Item properties if it had a value of 0.
  • Fixes bug where eo:cloud_cover was not stored or assigned to those bands/parameters/assets specified in the XML.

PR checklist:

  • Code is formatted (run scripts/format).
  • Code lints properly (run scripts/lint).
  • Tests pass (run scripts/test).
  • Documentation has been updated to reflect changes, if applicable.
  • Example STAC Catalog has been updated to reflect changes, if applicable.
  • Changes are added to the CHANGELOG.

@pjhartzell pjhartzell self-assigned this Jan 19, 2023
@pjhartzell pjhartzell changed the title fix: apply eo_cloud_cover to bands Correct missing eo:cloud_cover values Jan 19, 2023
@pjhartzell
Copy link
Contributor Author

@gadomski COG assets are currently not included in the example Items. They are included in this PR, but can be easily removed. Preference?

@gadomski
Copy link
Contributor

Preference?

Keep the COG assets -- the more STAC examples the better, I reckon.

@pjhartzell pjhartzell requested a review from gadomski January 19, 2023 19:54
gadomski
gadomski requested changes Jan 19, 2023
View reviewed changes
src/stactools/modis/builder.py Show resolved Hide resolved
src/stactools/modis/metadata.py Outdated Show resolved Hide resolved
@pjhartzell pjhartzell requested a review from gadomski January 19, 2023 21:55
@gadomski gadomski added this to the v0.3.0 milestone Jan 19, 2023
@pjhartzell pjhartzell merged commit b98f528 into main Jan 19, 2023
@pjhartzell pjhartzell deleted the issues/90-correct-cloud-cover branch January 19, 2023 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gadomski gadomski gadomski approved these changes

Assignees

@pjhartzell pjhartzell

Labels
None yet
Projects
None yet
Milestone
v0.3.0
Development

Successfully merging this pull request may close these issues.

eo:cloud_cover is never added to Assets
2 participants
@pjhartzell @gadomski