Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update for existing 2020 grid code errors #32

Merged
merged 5 commits into from
Feb 16, 2023

Conversation

pholleway
Copy link
Contributor

@pholleway pholleway commented Feb 14, 2023

Current package returns grid code errors on subset of 2020 items.

  • The grid code references the item id.
  • Item Id references xml, which contains incorrect str format for item Id.

The errors are resolved by having the item id reference another section in the xml (gmd:fileIdentifier) with correct str format.

@pholleway pholleway changed the title update for existing grid code error update for existing 2020 grid code error Feb 14, 2023
@pholleway pholleway changed the title update for existing 2020 grid code error update for existing 2020 grid code errors Feb 14, 2023
@pholleway pholleway marked this pull request as ready for review February 14, 2023 22:59
@philvarner
Copy link

Is there a test you can add?

@pholleway
Copy link
Contributor Author

Is there a test you can add?

@philvarner

  • added example data throwing the grid code error
  • added a test on the example data in test_stac.py

@philvarner philvarner merged commit e15d209 into stactools-packages:main Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants