Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spotify application #30

Open
NilsJacobsen opened this issue Feb 14, 2023 · 15 comments
Open

Spotify application #30

NilsJacobsen opened this issue Feb 14, 2023 · 15 comments

Comments

@NilsJacobsen
Copy link
Member

Write access application to Spotify

@felixhaeberle
Copy link
Contributor

@NiklasBuchfink can you look at this? 😁

@NiklasBuchfink
Copy link
Contributor

@felixhaeberle Can you provide me your settings for the Redirect URIs of the Spotify Dashboard?

@felixhaeberle
Copy link
Contributor

felixhaeberle commented Feb 15, 2023

Should be same as always.

Bildschirm­foto 2023-02-15 um 11 28 43

@NiklasBuchfink
Copy link
Contributor

Link to the commit: commit-link

✅ Access Token in Frontend
✅ Access Token in DB

ToDo:

  • Working update request (403 Access Denied - maybe because scope is missing in DB)
  • Refresh Token
  • Test Spotify Block

@felixhaeberle
Copy link
Contributor

Good progress 👍 You can paste the commit hash it will automatically create a link from the hash text either in minified / maximized version has version.

@NiklasBuchfink
Copy link
Contributor

Same request with token from developer console of Spotify works, so the scope seems to be the problem.

@NilsJacobsen
Copy link
Member Author

I thought the scope needs to be set in the spotify ui

@felixhaeberle
Copy link
Contributor

please check the PKCEClient code and check what's happening there with the scope when the request is coming back and how it gets persistent in the database via setToken and retrieved via getToken — please post investigation result here for further debugging help

@felixhaeberle
Copy link
Contributor

aaand don't know why we are putting that much effort in this although we don't have a working spotify oauth for everyone 😂

shouldn't we asked them first or how is the approval process there?

@NiklasBuchfink
Copy link
Contributor

The public application gets reviewed, that's why we have to do it now.

Btw update, just the access token called back is wrong, the rest works fine. Also the full revalidation flow is needed, because the expire time is 3600 sec / 1h.

@felixhaeberle
Copy link
Contributor

@NiklasBuchfink Hey, just checkin it – why is this assigned to me?

@NiklasBuchfink
Copy link
Contributor

aaand don't know why we are putting that much effort in this although we don't have a working spotify oauth for everyone 😂

shouldn't we asked them first or how is the approval process there?

Requirements:

image

@NiklasBuchfink
Copy link
Contributor

@felixhaeberle pls check if the src/client/api/connector.ts is fine regarding the typescript interfaces. The code_verifier must be passed through the authorizationRequest function and is optional for the authorize function.

Otherwise this issue can be closed 🎉🎵

@felixhaeberle
Copy link
Contributor

well done 🎉 what is left with the interfaces? are there errors? have you tested everything, also with the other APIs?

NiklasBuchfink added a commit that referenced this issue Feb 17, 2023
@NiklasBuchfink
Copy link
Contributor

No Errors, GitHub works as well. Just jf there is a prettier way to implement this with making the Prop optional and pass it through.

NilsJacobsen added a commit that referenced this issue Feb 27, 2023
@NiklasBuchfink NiklasBuchfink removed their assignment Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants