Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue of attention mask #9

Merged
merged 1 commit into from
Aug 27, 2024
Merged

Fix issue of attention mask #9

merged 1 commit into from
Aug 27, 2024

Conversation

martinakaduc
Copy link
Collaborator

No description provided.

@martinakaduc martinakaduc requested a review from LMorlok August 6, 2024 07:22
@martinakaduc martinakaduc linked an issue Aug 6, 2024 that may be closed by this pull request
Strange issues when creating attention mask manually #8
Closed
LMorlok
LMorlok approved these changes Aug 9, 2024
View reviewed changes
Copy link
Collaborator

@LMorlok LMorlok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a nice simplification to the code! :)

@sangttruong sangttruong merged commit 6811550 into main Aug 27, 2024
0 of 3 checks passed
@sangttruong sangttruong deleted the 8-fix-strange-issues-with-attention-mask branch August 27, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LMorlok LMorlok LMorlok approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Strange issues when creating attention mask manually
3 participants
@martinakaduc @LMorlok @sangttruong