-
Notifications
You must be signed in to change notification settings - Fork 520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a annotation flag to trigger rollout on change of cm/secrets #771
base: master
Are you sure you want to change the base?
Adding a annotation flag to trigger rollout on change of cm/secrets #771
Conversation
@MuneebAijaz Can i get some maintainers reviews? |
@MuneebAijaz @karl-johan-grahn Would appreciate 👀 and reviews on this whenever possible! |
@wololowarrior can you please add a unit test for this? You can take inspiration from existing tests |
…ithub.com/wololowarrior/Reloader into rollout_flag_to_trigger_rollout_on_change
@karl-johan-grahn Added a test for rollout. Weirdly there weren't any tests for it so more code than usual. I also tried writing a test for the case where its a rolling update, but that test doesn't seem to pass. I suspect this is because the stubbed rollout client isnt built to handle |
…ithub.com/wololowarrior/Reloader into rollout_flag_to_trigger_rollout_on_change
@karl-johan-grahn fixed ci. |
Fixes #773
#724 This pr removed the functionality of triggering a rollout strategy on change of configmap/secrets.
But there are some cases when we want to trigger a rollout instead of just restarting the pod.
As part of this pr,
reloader.stakater.com/triggerRollout
if set totrue
will trigger a rollout strategy for that rollout. The default can be unset orfalse
, so current behaviour should continue on.Example
Setting as true